Skip to content

Improve consistency of Julia code for Gaussian elimination #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2018
Merged

Improve consistency of Julia code for Gaussian elimination #269

merged 1 commit into from
Jul 18, 2018

Conversation

mika314
Copy link
Contributor

@mika314 mika314 commented Jul 18, 2018

  • rename gauss_jordan function to gauss_jordan_elimination
  • do gauss_jordan_elimination in-place, to match with gaussian_elimination

@mika314
Improve consistency of Julia code for Gaussian elimination
eb3078c 
- rename gauss_jordan function to gauss_jordan_elimination
- do gauss_jordan_elimination in-place, to match with gaussian_elimination
@Butt4cak3 Butt4cak3 requested a review from leios July 18, 2018 09:27
leios
leios reviewed Jul 18, 2018
View reviewed changes
Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This makes the code a bit more consistent

@leios leios merged commit c0ce24b into algorithm-archivists:master Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leios leios leios approved these changes

Assignees

@leios leios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mika314 @leios